[
https://issues.apache.org/jira/browse/HDFS-11770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018435#comment-16018435
]
Xiaoyu Yao commented on HDFS-11770:
-----------------------------------
Thanks [~msingh] for the update with additional tests. The patch looks pretty
good to me. Here a few minor issues:
KeySpaceManagerProtocol.java
NIT: line 70 extra "the" can be removed.
KeySpaceManagerProtocolClientSideTranslatorPB.java
NIT: line 210 same as above
KeySpaceManager.java
NIT: line 296 same as above
VolumeManagerImpl.java
Line 107-111: in delVolumeFromOwnerList()
when all the volume of a user is deleted, should we remove the empty user entry
instead of
updating the empty user entry?
DistributedStorageHandler.java
Line 164-167: We should set the Quota in the VolumeInfo returned here
to validate the SetQuota that has been implemented here.
TestKeySpaceManager.java
Can we add test for SetQuota with the getVolumeInfo support?
Checkstyle from latest Jenkins.
> Ozone: KSM: Add setVolumeProperty
> ---------------------------------
>
> Key: HDFS-11770
> URL: https://issues.apache.org/jira/browse/HDFS-11770
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Anu Engineer
> Assignee: Mukul Kumar Singh
> Fix For: HDFS-7240
>
> Attachments: HDFS-11770-HDFS-7240.001.patch,
> HDFS-11770-HDFS-7240.002.patch, HDFS-11770-HDFS-7240.003.patch,
> HDFS-11770-HDFS-7240.005.patch
>
>
> SetVolumeProperty allows Ozone administrators to change the ownership of a
> volume and quota.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
