[ 
https://issues.apache.org/jira/browse/HDFS-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021360#comment-16021360
 ] 

Nandakumar commented on HDFS-11778:
-----------------------------------

Thanks for the review [~msingh].

BuckerManagerImpl: 85, 129 please correct the comment
-> moved it to MetadataManagerImpl.java
KeySpaceManager:366, please add a new metric, and update it here
-> done
KeySpaceManagerProtocol:114, variable name in comments are not correct
-> corrected
BucketManagerImpl:97 - the acls during creation should be fetched from the 
KsmBucketInfo.
-> KsmBucketInfo is created at this point with the values from KsmBucketArgs, 
for acls the value is read from KsmBucketArgs#addAcls
It would be great if we can add a test to TestKeySpaceManager, this will help 
with end to end testing for all the APIs.
-> updated TestKeySpaceManager with a new test case for verifying creation and 
retrieving of bucket info.


> Ozone: KSM: add getBucketInfo
> -----------------------------
>
>                 Key: HDFS-11778
>                 URL: https://issues.apache.org/jira/browse/HDFS-11778
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Nandakumar
>         Attachments: HDFS-11778-HDFS-7240.000.patch, 
> HDFS-11778-HDFS-7240.001.patch
>
>
> Returns the bucket information if the bucket exists.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to