[
https://issues.apache.org/jira/browse/HDFS-11853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027019#comment-16027019
]
Xiaoyu Yao commented on HDFS-11853:
-----------------------------------
Thanks [~vagarychen] for the patch. The patch looks great to me overall. Here
are a few minor issues.
DistributedStorageHandler.java
Line 345: why we are using args.getKeyName() not the containerKey to read from
ChunkInputStream? I remember we use containerKey (/Volume/Bucket/Key) for write
with ChunkOutputStream.
KSMKeyMetrics.java
Line 170: typo: "getNumKeyAllocateFailes" -> "getNumKeyAllocateFails"
TestKeySpaceManager.java
Line 325-331. you can use the ExpectedException from junit to verify the
negative case.
> Ozone: KSM: Add getKey
> -----------------------
>
> Key: HDFS-11853
> URL: https://issues.apache.org/jira/browse/HDFS-11853
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Chen Liang
> Attachments: HDFS-11853-HDFS-7240.001.patch,
> HDFS-11853-HDFS-7240.002.patch
>
>
> Support read the content (object) of the key.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
