[
https://issues.apache.org/jira/browse/HDFS-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028395#comment-16028395
]
Yiqun Lin edited comment on HDFS-11779 at 5/29/17 2:17 PM:
-----------------------------------------------------------
Thanks [~cheersyang] for updated patch. Just catch one nit in latest patch:
{code}
+ int maxNumOfKeys = args.getMaxKeys();
+ if (maxNumOfKeys < 0 ||
+ maxNumOfKeys > OzoneConsts.MAX_LISTBUCKETS_SIZE) {
+ throw new IllegalArgumentException(
+ String.format("Illegal max number of keys specified,"
+ + " the value must be in range (0, %d), actual : %d.",
+ OzoneConsts.MAX_LISTBUCKETS_SIZE, maxNumOfKeys));
+ }
{code}
The {{maxNumOfKeys < 0}} should be {{maxNumOfKeys <=0}}, var {{maxNumOfKeys}}
should be a positive number.
was (Author: linyiqun):
Thanks [~cheersyang] for updated patch. Just catch one nit in latest patch:
{code}
+ int maxNumOfKeys = args.getMaxKeys();
+ if (maxNumOfKeys < 0 ||
+ maxNumOfKeys > OzoneConsts.MAX_LISTBUCKETS_SIZE) {
+ throw new IllegalArgumentException(
+ String.format("Illegal max number of keys specified,"
+ + " the value must be in range (0, %d), actual : %d.",
+ OzoneConsts.MAX_LISTBUCKETS_SIZE, maxNumOfKeys));
+ }
{code}
The {{maxNumOfKeys < 0}} should be {{maxNumOfKeys <=0 }}, var {{maxNumOfKeys}}
should be a positive number.
> Ozone: KSM: add listBuckets
> ---------------------------
>
> Key: HDFS-11779
> URL: https://issues.apache.org/jira/browse/HDFS-11779
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Weiwei Yang
> Attachments: HDFS-11779-HDFS-7240.001.patch,
> HDFS-11779-HDFS-7240.002.patch, HDFS-11779-HDFS-7240.003.patch,
> HDFS-11779-HDFS-7240.004.patch, HDFS-11779-HDFS-7240.005.patch,
> HDFS-11779-HDFS-7240.006.patch, HDFS-11779-HDFS-7240.007.patch
>
>
> Lists buckets of a given volume. Similar to listVolumes, paging supported via
> prevKey, prefix and maxKeys.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
