[
https://issues.apache.org/jira/browse/HDFS-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026536#comment-16026536
]
Xiao Chen edited comment on HDFS-11741 at 5/30/17 5:23 PM:
-----------------------------------------------------------
Thanks for revving Wei-Chiu, good analysis!
As talked offline I think generating new DEK would be sufficient.
Prefer the {{encryptionKey.expiryDate - keyUpdateInterval / 4 * 3 <
timer.now()}} route to prevent TOCTOU as Andrew pointed out earlier.
Nits:
- {{LOG.debug("Getting new encryption token from NN");}} IIUC this is local
- Please remove the stale changes in {{TestBalancerWithEncryptedTransfer}} and
{{Dispatcher}}
- I think the test case in {{TestKeyManager}} needs updating after the 3/4
interval change - new DEK not generated based on expiry, but actually on BK's
update interval. Maybe we can choose different updateInterval and tokenLifetime
to differentiate it in the test.
- Let's use a safer test timeout to reduce false positives due to infra.
was (Author: xiaochen):
Thanks for revving Wei-Chiu, good analysis!
As talked offline I think generating new DEK would be sufficient.
Prefer the {{encryptionKey.expiryDate - keyUpdateInterval * 3 / 4 < timer.now()
}} route to prevent TOCTOU as Andrew pointed out earlier.
Nits:
- {{LOG.debug("Getting new encryption token from NN");}} IIUC this is local
- Please remove the space change in {{TestBalancerWithEncryptedTransfer}}
- I think the test case in {{TestKeyManager}} needs updating after the 3/4
interval change - new DEK not generated based on expiry, but actually on BK's
update interval. Maybe we can choose different updateInterval and tokenLifetime
to differentiate it in the test.
- Let's use a safer test timeout to reduce false positives due to infra.
> Long running balancer may fail due to expired DataEncryptionKey
> ---------------------------------------------------------------
>
> Key: HDFS-11741
> URL: https://issues.apache.org/jira/browse/HDFS-11741
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Environment: CDH5.8.2, Kerberos, Data transfer encryption enabled.
> Balancer login using keytab
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Attachments: block keys.png, HDFS-11741.001.patch,
> HDFS-11741.002.patch, HDFS-11741.003.patch, HDFS-11741.004.patch,
> HDFS-11741.005.patch
>
>
> We found a long running balancer may fail despite using keytab, because
> KeyManager returns expired DataEncryptionKey, and it throws the following
> exception:
> {noformat}
> 2017-04-30 05:03:58,661 WARN [pool-1464-thread-10] balancer.Dispatcher
> (Dispatcher.java:dispatch(325)) - Failed to move blk_1067352712_3913241 with
> size=546650 from 10.0.0.134:50010:DISK to 10.0.0.98:50010:DISK through
> 10.0.0.134:50010
> org.apache.hadoop.hdfs.protocol.datatransfer.InvalidEncryptionKeyException:
> Can't re-compute encryption key for nonce, since the required block key
> (keyID=1005215027) doesn't exist. Current key: 1005215030
> at
> org.apache.hadoop.hdfs.protocol.datatransfer.sasl.DataTransferSaslUtil.readSaslMessageAndNegotiatedCipherOption(DataTransferSaslUtil.java:417)
> at
> org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslDataTransferClient.doSaslHandshake(SaslDataTransferClient.java:474)
> at
> org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslDataTransferClient.getEncryptedStreams(SaslDataTransferClient.java:299)
> at
> org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslDataTransferClient.send(SaslDataTransferClient.java:242)
> at
> org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslDataTransferClient.checkTrustAndSend(SaslDataTransferClient.java:211)
> at
> org.apache.hadoop.hdfs.protocol.datatransfer.sasl.SaslDataTransferClient.socketSend(SaslDataTransferClient.java:183)
> at
> org.apache.hadoop.hdfs.server.balancer.Dispatcher$PendingMove.dispatch(Dispatcher.java:311)
> at
> org.apache.hadoop.hdfs.server.balancer.Dispatcher$PendingMove.access$2300(Dispatcher.java:182)
> at
> org.apache.hadoop.hdfs.server.balancer.Dispatcher$1.run(Dispatcher.java:899)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> This bug is similar in nature to HDFS-10609. While balancer KeyManager
> actively synchronizes itself with NameNode w.r.t block keys, it does not
> update DataEncryptionKey accordingly.
> In a specific cluster, with Kerberos ticket life time 10 hours, and default
> block token expiration/life time 10 hours, a long running balancer failed
> after 20~30 hours.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
