[
https://issues.apache.org/jira/browse/HDFS-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035605#comment-13035605
]
[email protected] commented on HDFS-1013:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/754/#review682
-----------------------------------------------------------
a few preliminary comments. I also want to load this up and see how it looks :)
trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
<https://reviews.apache.org/r/754/#comment1362>
these lines are missing </td> and </tr> still
trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
<https://reviews.apache.org/r/754/#comment1363>
missing </td></tr> on this line and lines below
trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
<https://reviews.apache.org/r/754/#comment1364>
do we need warning class on both the div and the a?
trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
<https://reviews.apache.org/r/754/#comment1365>
can we kill off these table attributes and use CSS styles to style all the
tables consistently?
- Todd
On 2011-05-18 19:17:02, Todd Lipcon wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/754/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-18 19:17:02)
bq.
bq.
bq. Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Uploading Eugene's patch
https://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch for
easier review
bq.
bq.
bq. This addresses bug HDFS-1013.
bq. https://issues.apache.org/jira/browse/HDFS-1013
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
1124363
bq.
trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
1124363
bq. trunk/src/webapps/hdfs/dfshealth.jsp 1124363
bq. trunk/src/webapps/static/hadoop.css PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/754/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Todd
bq.
bq.
> Miscellaneous improvements to HTML markup for web UIs
> -----------------------------------------------------
>
> Key: HDFS-1013
> URL: https://issues.apache.org/jira/browse/HDFS-1013
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Todd Lipcon
> Assignee: Eugene Koontz
> Priority: Minor
> Labels: newbie
> Fix For: 0.20.3
>
> Attachments: HDFS-1013.patch
>
>
> The Web UIs have various bits of bad markup (eg missing <head> sections, some
> pages missing CSS links, inconsistent td vs th for table headings). We should
> fix this up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
