[
https://issues.apache.org/jira/browse/HDFS-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LiXin Ge updated HDFS-11927:
----------------------------
Status: Open (was: Patch Available)
> hdfs oiv_legacy:Normalize the verification of input parameter
> -------------------------------------------------------------
>
> Key: HDFS-11927
> URL: https://issues.apache.org/jira/browse/HDFS-11927
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: tools
> Affects Versions: 3.0.0-alpha3
> Reporter: LiXin Ge
> Assignee: LiXin Ge
> Attachments: HDFS-11927.002.patch, HDFS-11927.patch
>
>
> At present, hdfs oiv_legacy tool lacks in verification of input
> parameter.people can type in irrelevant option like:
> bq../hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML -step 1024
> or type in option with wrong format which he think come into effec but
> actually not:
> bq../hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p
> FileDistribution maxSize 4096 step 512 format
> or some meaningless word which can also get through:
> bq../hdfs oiv_legacy -i fsimage_0000000000000000000 -o out -p XML Hello World
> We'd better not let these cases go unchecked.
> By the way, this patch fixed some checkstyle warnings in
> +DelimitedImageVisitor.java+
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
