[ 
https://issues.apache.org/jira/browse/HDFS-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040906#comment-16040906
 ] 

Rushabh S Shah edited comment on HDFS-11804 at 6/7/17 1:50 PM:
---------------------------------------------------------------

Added new patch to address checkstyle warnings.
The test failures from the previous build are unrelated :
||Failed test||Comment||
|hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |Passing 
locally|
|hadoop.hdfs.TestAclsEndToEnd |Created HDFS-11944|
|hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure|Passing locally|
|hadoop.hdfs.server.namenode.TestDecommissioningStatus|Passing locally|
|hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150|Passing locally|
|hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy|Passing 
locally|
|hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy|Passing locally|
Also none of the findbugs warnings are related to my patch.

[~xiaochen] [~daryn] please review the latest patch.



was (Author: shahrs87):
Added new patch to address checkstyle warnings.
The test failures from the previous build are unrelated :
||Failed test||Comment||
|hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem |Passing 
locally|
|hadoop.hdfs.TestAclsEndToEnd |Created HDFS-11944|
|hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure|Passing locally|
|hadoop.hdfs.server.namenode.TestDecommissioningStatus|Passing locally|
|hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150|Passing locally|
|hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy|Passing 
locally|
|hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy|Passing locally|

[~xiaochen] [~daryn] please review the latest patch.


> KMS client needs retry logic
> ----------------------------
>
>                 Key: HDFS-11804
>                 URL: https://issues.apache.org/jira/browse/HDFS-11804
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>         Attachments: HDFS-11804-trunk-1.patch, HDFS-11804-trunk-2.patch, 
> HDFS-11804-trunk-3.patch, HDFS-11804-trunk.patch
>
>
> The kms client appears to have no retry logic – at all.  It's completely 
> decoupled from the ipc retry logic.  This has major impacts if the KMS is 
> unreachable for any reason, including but not limited to network connection 
> issues, timeouts, the +restart during an upgrade+.
> This has some major ramifications:
> # Jobs may fail to submit, although oozie resubmit logic should mask it
> # Non-oozie launchers may experience higher rates if they do not already have 
> retry logic.
> # Tasks reading EZ files will fail, probably be masked by framework reattempts
> # EZ file creation fails after creating a 0-length file – client receives 
> EDEK in the create response, then fails when decrypting the EDEK
> # Bulk hadoop fs copies, and maybe distcp, will prematurely fail



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to