[
https://issues.apache.org/jira/browse/HDFS-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043207#comment-16043207
]
Hanisha Koneru commented on HDFS-11947:
---------------------------------------
In the following code, we are calling _bpos.getBlockPoolId()_ twice. This
function needs a read lock. Would be better to call the function once and use
the same return value?
{code}
final String prefix = bpos.getBlockPoolId(true) != null ?
bpos.getBlockPoolId(true) : bpos.getNameserviceId();
{code}
> When constructing a thread name, BPOfferService may print a bogus warning
> message
> ----------------------------------------------------------------------------------
>
> Key: HDFS-11947
> URL: https://issues.apache.org/jira/browse/HDFS-11947
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Weiwei Yang
> Priority: Minor
> Attachments: HDFS-11947.001.patch, HDFS-11947.002.patch
>
>
> HDFS-11558 tries to get Block pool ID for constructing thread names. When
> the service is not yet registered with NN, it prints the bogus warning "Block
> pool ID needed, but service not yet registered with NN" with stack trace.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
