[ 
https://issues.apache.org/jira/browse/HDFS-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043424#comment-16043424
 ] 

John Zhuge commented on HDFS-11954:
-----------------------------------

On branch-2, {{TestClientProtocolWithDelegationToken.testDelegationTokenRpc}} 
NPE:
{noformat}
testDelegationTokenRpc(org.apache.hadoop.hdfs.security.TestClientProtocolWithDelegationToken)
  Time elapsed: 3.241 sec  <<< ERROR!
java.lang.NullPointerException: null
        at 
org.apache.hadoop.ipc.WritableRpcEngine$Invocation.toString(WritableRpcEngine.java:185)
        at java.lang.String.valueOf(String.java:2994)
        at java.lang.StringBuilder.append(StringBuilder.java:131)
        at org.apache.hadoop.ipc.Client$Connection$3.run(Client.java:1114)
        at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
{noformat}
And {{TestClientToAMTokens}} NPE:
{noformat}
  <testcase name="testClientToAMTokens" 
classname="org.apache.hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens"
 time="5.759">
    <error 
type="java.lang.NullPointerException:">java.lang.NullPointerException: null
        at 
org.apache.hadoop.ipc.WritableRpcEngine$Invocation.toString(WritableRpcEngine.java:185)
        at java.lang.String.valueOf(String.java:2994)
        at java.lang.StringBuilder.append(StringBuilder.java:131)
        at org.apache.hadoop.ipc.Client$Connection$3.run(Client.java:1114)
        at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
{noformat}

> WritableRpcEngine.Invocation#toString should handle null parameters
> -------------------------------------------------------------------
>
>                 Key: HDFS-11954
>                 URL: https://issues.apache.org/jira/browse/HDFS-11954
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.8.0
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>
> WritableRpcEngine.Invocation#toString will throw NPE if {{parameters}} is 
> null:
> {code:title=WritableRpcEngine.Invocation#toString}
>       buffer.append(methodName);
>       buffer.append("(");
>       for (int i = 0; i < parameters.length; i++) {
>         if (i != 0)
>           buffer.append(", ");
>         buffer.append(parameters[i]);
>       }
>       buffer.append(")");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to