[
https://issues.apache.org/jira/browse/HDFS-11933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045797#comment-16045797
]
lufei commented on HDFS-11933:
------------------------------
Thanks [~vagarychen] for the review.So far I have not yet met
??composePolicyName?? was given invalid arguments. But I think after the valid
check on these parameters, function ??composePolicyName?? may be safer and it
can also prevent problems caused by subsequent changes(give invalid arguments's
callers).
> The function composePolicyName should judge arguments not NULL
> ---------------------------------------------------------------
>
> Key: HDFS-11933
> URL: https://issues.apache.org/jira/browse/HDFS-11933
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 3.0.0-alpha3
> Reporter: lufei
> Priority: Minor
> Attachments: HDFS-11933.001.patch
>
>
> Function composePolicyName is called by ErasureCodingPolicy, but both of them
> are not judge the arguments not NULL.It 's better to judge in the function
> composePolicyName.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
