[
https://issues.apache.org/jira/browse/HDFS-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048700#comment-16048700
]
Anu Engineer commented on HDFS-11972:
-------------------------------------
Thank you for filing this, I will cleanup both CBlockServer and Ozone.
> CBlocks use wrong OPT env vars
> ------------------------------
>
> Key: HDFS-11972
> URL: https://issues.apache.org/jira/browse/HDFS-11972
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Allen Wittenauer
> Assignee: Mukul Kumar Singh
>
> Current codebase does:
> {code}
> hadoop_debug "Appending HADOOP_CBLOCK_OPTS onto HADOOP_OPTS"
> HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_CBLOCK_OPTS}"
> ...
> hadoop_debug "Appending HADOOP_JSCSI_OPTS onto HADOOP_OPTS"
> HADOOP_OPTS="${HADOOP_OPTS} ${HADOOP_JSCSI_OPTS}"
> {code}
> This code block breaks the consistency with the rest of the shell scripts:
> a) It should be HDFS_CBLOCKSERVER_OPTS, HDFS_JSCSI_OPTS
> b) _OPTS, unless they are a deprecated form or some other special case, are
> already/automatically appended; there is no need to do them specifically
> Also, a description of these env vars should be hadoop-env.sh for
> documentation purposes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
