[ 
https://issues.apache.org/jira/browse/HDFS-11870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060502#comment-16060502
 ] 

Wei-Chiu Chuang commented on HDFS-11870:
----------------------------------------

Hi lufei, thanks for the patch and it looks like it's doing what it's supposed 
to do.

Quickly glanced the patch, would you please make sure
# NameNodeRpcServer verifies the request has super user permission 
{code}namesystem.checkSuperuserPrivilege();{code}
# Append "// ClientProtocol" after {quote}@Override{quote}
{code}
@Override
  public void enableErasureCodingPolicy(String ecPolicyName)
{code}
# Please log messages to record what policy is enabled/disabled, either in 
ErasureCodingPolicyManage or in FSNamesystem.
# In FSNamesystem, please call checkNameNodeSafeMode() to ensure NN is not in 
safemode.
# test: please also test the case when you enable/disable a policy that doesn't 
exist.

> Add CLI cmd to enable/disable an erasure code policy
> ----------------------------------------------------
>
>                 Key: HDFS-11870
>                 URL: https://issues.apache.org/jira/browse/HDFS-11870
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: erasure-coding
>            Reporter: SammiChen
>            Assignee: lufei
>              Labels: hdfs-ec-3.0-nice-to-have
>         Attachments: HDFS-11870.001.patch
>
>
> This task is to develop a CLI command to help user enable or disable and 
> existing erasure coding policy. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to