[
https://issues.apache.org/jira/browse/HDFS-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061279#comment-16061279
]
Chen Liang commented on HDFS-11993:
-----------------------------------
Thanks [~candychencan] for the patch. Since this seems to be slf4j logger, how
about considering using {} placeholders? e.g.
{code}
DFSClient.LOG.warn("Failed to connect to " + targetAddr + " for block " +
targetBlock.getBlock() + ", add to deadNodes and continue. " + ex, ex);
{code}
to something like
{code}
DFSClient.LOG.warn("Failed to connect to {} for block {}, add to deadNodes and
continue. ", targetAddr, targetBlock.getBlock(), ex);
{code}
> Add log info when connect to datanode socket address failed
> -----------------------------------------------------------
>
> Key: HDFS-11993
> URL: https://issues.apache.org/jira/browse/HDFS-11993
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Reporter: chencan
> Assignee: chencan
> Attachments: HADOOP-11993.patch
>
>
> In function BlockSeekTo, when connect faild to datanode socket address,log as
> follow:
> DFSClient.LOG.warn("Failed to connect to " + targetAddr + " for block"
> + ", add to deadNodes and continue. " + ex, ex);
> add block info may be more explicit.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
