[
https://issues.apache.org/jira/browse/HDFS-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063447#comment-16063447
]
Xiaoyu Yao commented on HDFS-12018:
-----------------------------------
Thanks [~vagarychen] for working on this. The patch looks good to me. I just
have a few minor issues below:
*ozone-default.xml*
Line 520: dfs.cblock.cache.core.pool.size ->
dfs.cblock.cache.core.min.pool.size to be consistent with the
dfs.cblock.cache.max.pool.size
Line 523: Minimum number of thread pool thread that cBlock cache will use for
background I/O.
Line 531: Maximum number of thread pool thread that cBlcok cache will use for
background I/O.
Line 548: "Can be 1, 5 or 10 for now" -> "Supported values are 1, 5, 10. Use 1
for high priority and 10 for low priority?
Line 569: dfs.cblock.jscsi.server.address can this be a host:port or just host
or both?
Line 578: same as above
> Ozone: Misc: Add CBlocks defaults to ozone-defaults.xml
> -------------------------------------------------------
>
> Key: HDFS-12018
> URL: https://issues.apache.org/jira/browse/HDFS-12018
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Chen Liang
> Priority: Trivial
> Attachments: HDFS-12018-HDFS-7240.001.patch
>
>
> We have just updated ozone-defaults.xml in HDFS-11990. This JIRA tracks the
> issue that we need to the same for CBlocks, since CBlock uses Ozone's Config
> files.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
