[
https://issues.apache.org/jira/browse/HDFS-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065636#comment-16065636
]
Xiaoyu Yao commented on HDFS-10391:
-----------------------------------
*NameNode.java*
Line 507: should we document the change of service rpc port fallback behavior
somewhere, e.g. hdfs-default.xml?
*NamenodeRpcServer.java*
Line 329-330: I think we should remove the additional logic to try getting the
service RPC bind host based on the RPC bind host settings.
Many times, I’ve seen that the client RPC around bind to external IP only and
the service RPC are bind to internal IP.
{code}
if (bindHost == null) {
bindHost = nn.getRpcServerBindHost(conf);
…
{code}
Line 343-345: should we ensure only the service RPCs are added/set here?
{code}
.setProtocol(
org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolPB.class)
.setInstance(clientNNPbService)
{code}
Line 433-463 (original NamenodeRPCServer.java): should we remove the service
related RPCs from the client RPC server as we are not allow fallback
after this change?
*TestDFSUtil.java*
Line 1048: can we add some test with/wo service rpc/rpc binding host?
*TestDataNodeMetricsLogger.java*
NIT: Line 123/130/137/152: can we use a single timeout rule instead of
specifying the same individually?
Please file follow up JIRAs for the ignored tests.
> Always enable NameNode service RPC port
> ---------------------------------------
>
> Key: HDFS-10391
> URL: https://issues.apache.org/jira/browse/HDFS-10391
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode, namenode
> Reporter: Arpit Agarwal
> Assignee: Gergely Novák
> Labels: Incompatible
> Attachments: HDFS-10391.001.patch, HDFS-10391.002.patch,
> HDFS-10391.003.patch, HDFS-10391.004.patch, HDFS-10391.005.patch,
> HDFS-10391.006.patch, HDFS-10391.007.patch, HDFS-10391.v5-v6-delta.patch
>
>
> The NameNode should always be setup with a service RPC port so that it does
> not have to be explicitly enabled by an administrator.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
