[
https://issues.apache.org/jira/browse/HDFS-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070937#comment-16070937
]
Ming Ma commented on HDFS-9388:
-------------------------------
Thanks [~manojg]. Looks good over all. Couple nits:
* Configuration keys DFS_NAMENODE_DECOMMISSION_* only mentioned decommission in
hdfs-default.xml. Better to use general term like admin, or include maintenance.
* Comments in functions like handleInsufficientlyStored and
processBlocksInternal refer to decommission only; would be useful to update the
comments.
* The checkstyle and whitespace might not be related to the change. Still it
will be nice to fix them if it isn't too much effort.
> Refactor decommission related code to support maintenance state for datanodes
> -----------------------------------------------------------------------------
>
> Key: HDFS-9388
> URL: https://issues.apache.org/jira/browse/HDFS-9388
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha1
> Reporter: Ming Ma
> Assignee: Manoj Govindassamy
> Attachments: HDFS-9388.01.patch
>
>
> Lots of code can be shared between the existing decommission functionality
> and to-be-added maintenance state support for datanodes. To make it easier to
> add maintenance state support, let us first modify the existing code to make
> it more general.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
