[ 
https://issues.apache.org/jira/browse/HDFS-12023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anu Engineer updated HDFS-12023:
--------------------------------
    Attachment: HDFS-12023-HDFS-7240.003.patch


[~elek] During testing I found some issues, those issues are fixed in the ver 3 
of the patch.

# I added {{errorIfMissingConfigProps = true;}} that showed that we were 
missing a huge set of CBlock configurations. 
# So I added {{CBlockConfigKeys.class}} to the set of config keys to check for.
# This still leads to 5 keys which are not configured correctly.  So when we 
commit this JIRA, this test will fail until CBlock issues are corrected. 
# I think this is the right approach to take, [~cheersyang] can you please 
review this change and comment on issue of having a brief period where this 
test would be failing until CBlock issues are fixed.

[~vagarychen] and [~msingh] Please note that we will have to add these fields 
in the defaults or remove them if not needed for this test to succeed.

{noformat}
  dfs.cblock.scm.ipaddress
  dfs.cblock.scm.port
  dfs.cblock.jscsi-address
  dfs.cblock.service.rpc-bind-host
  dfs.cblock.jscsi.rpc-bind-host
{noformat}


> Ozone: Test if all the configuration keys are documented in ozone-defaults.xml
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-12023
>                 URL: https://issues.apache.org/jira/browse/HDFS-12023
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>              Labels: test
>         Attachments: HDFS-12023-HDFS-7240.001.patch, 
> HDFS-12023-HDFS-7240.002.patch, HDFS-12023-HDFS-7240.003.patch
>
>
> HDFS-11990 added the missing configuration entries the ozone-defaults.xml
> This patch contains a unit test which tests if all the configuration keys are 
> still documented.
> (constant fields of the specific configuration classes which ends with _KEY 
> should be part of the defaults.xml). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to