[
https://issues.apache.org/jira/browse/HDFS-12026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anatoli Shein updated HDFS-12026:
---------------------------------
Attachment: HDFS-12026.HDFS-8707.002.patch
Thanks for the reveiw, [~James C].
* I was able to remove the ASIO dependency on the libraries libc++ and
libc++abi, and now the build should work out-of-the-box as long as clang is
installed and protoc was compiled with clang. This fix also allowed me to
remove the ugly hacks in hdfs.cc and logging.cc.
* I moved the underscores for consistency as you mentioned above.
* For updating the dockerfile and the CI system we should probably create
another JIRA. Also, I have not yet added a try_compile for checking whether
build fail is caused by the protoc version. The cmake documentation for
try_compile is limited, maybe it is easier to just add a message saying
somthing along the lines "if you get protoc errors please make sure it is
compiled with clang".
* In optional_wrapper.h the pragmas for ignoring warnings are due to ones in
the third-party header optional.hpp, which we probably should not change
ourselves.
Please see the new patch.
> libhdfspp: Fix compilation errors and warnings when compiling with Clang
> -------------------------------------------------------------------------
>
> Key: HDFS-12026
> URL: https://issues.apache.org/jira/browse/HDFS-12026
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Anatoli Shein
> Assignee: Anatoli Shein
> Attachments: HDFS-12026.HDFS-8707.000.patch,
> HDFS-12026.HDFS-8707.001.patch, HDFS-12026.HDFS-8707.002.patch
>
>
> Currently multiple errors and warnings prevent libhdfspp from being compiled
> with clang. It should compile cleanly using flags:
> -std=c++11 -stdlib=libc++
> and also warning flags:
> -Weverything -Wno-c++98-compat -Wno-missing-prototypes
> -Wno-c++98-compat-pedantic -Wno-padded -Wno-covered-switch-default
> -Wno-missing-noreturn -Wno-unknown-pragmas -Wconversion -Werror
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
