[
https://issues.apache.org/jira/browse/HDFS-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manoj Govindassamy updated HDFS-9388:
-------------------------------------
Attachment: HDFS-9388.02.patch
Thanks for the review [~mingma]. Attached v02 patch addressing the following
comments. Can you please take a look at the latest patch ?
bq. Configuration keys DFS_NAMENODE_DECOMMISSION_* only mentioned decommission
in hdfs-default.xml. Better to use general term like admin, or include
maintenance.
Updated hdfs-default.xml to mention on maintenance for these config params.
But, I have not changed the config param strings yet. In order to rename these
config key strings to a new one, we need to deprecate the current ones and
introduce new ones. Will you be ok, if we can take this deprecation alone in a
separate jira ?
bq. Comments in functions like handleInsufficientlyStored and
processBlocksInternal refer to decommission only; would be useful to update the
comments.
Updated the comments to mention about the maintenance.
bq. The checkstyle and whitespace might not be related to the change. Still it
will be nice to fix them if it isn't too much effort.
Fixed the checkstyle and bunch of space issues in the new file. Will watch out
for new ones in the new patch and fix them if needed.
> Refactor decommission related code to support maintenance state for datanodes
> -----------------------------------------------------------------------------
>
> Key: HDFS-9388
> URL: https://issues.apache.org/jira/browse/HDFS-9388
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.0.0-alpha1
> Reporter: Ming Ma
> Assignee: Manoj Govindassamy
> Attachments: HDFS-9388.01.patch, HDFS-9388.02.patch
>
>
> Lots of code can be shared between the existing decommission functionality
> and to-be-added maintenance state support for datanodes. To make it easier to
> add maintenance state support, let us first modify the existing code to make
> it more general.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
