[ 
https://issues.apache.org/jira/browse/HDFS-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076043#comment-16076043
 ] 

Weiwei Yang commented on HDFS-11679:
------------------------------------

Hi [~yuanbo]

Thanks for the updates. Mostly seem good to me, I think we just need to address 
2 issues please

1. {{-start}} should be optional
{code}
 -start <arg>    Specify start container name, required
{code}

We need to make {{-start}} argument optional. If it is not given, then list the 
first container. This is how user to use this CLI. User doesn't know a 
container name for the first call at most of the time.

2. When output json, can we use pretty printer. In pipeline, can we init 
WRITTER like following?

{code}
ObjectWriter WRITTER = MAPPER.writerWithDefaultPrettyPrinter();
{code}

thanks

> Ozone: SCM CLI: Implement list container command
> ------------------------------------------------
>
>                 Key: HDFS-11679
>                 URL: https://issues.apache.org/jira/browse/HDFS-11679
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Yuanbo Liu
>              Labels: command-line
>         Attachments: HDFS-11679-HDFS-7240.001.patch, 
> HDFS-11679-HDFS-7240.002.patch, HDFS-11679-HDFS-7240.003.patch, 
> HDFS-11679-HDFS-7240.004.patch
>
>
> Implement the command to list containers
> {code}
> hdfs scm -container list -start <container name> [-count <100> | -end 
> <name>]{code}
> Lists all containers known to SCM. The option -start allows the listing to 
> start from a specified container and -count controls the number of entries 
> returned but it is mutually exclusive with the -end option which returns keys 
> from the -start to -end range.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to