[ 
https://issues.apache.org/jira/browse/HDFS-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078714#comment-16078714
 ] 

Nathan Roberts commented on HDFS-12102:
---------------------------------------

Hi [~aramesh2]. Thanks for the patch. Couple of quick comments (I'll look more 
closely early next week)
- Need to change hdfs-default.xml to include new config options
- LOG.debug statements should be surrounded by if (LOG.isDebugEnabled()) checks 
(reduces overhead)
- Is it possible to disable the fast-scan behavior all together (i.e. might be 
good for default behavior to remain the same. If someone want's fast-scan, they 
have to enable it). Maybe setting the period to -1 could be a way?
- Description of corruptBlockThreshold doesn't really match its use. I think 
it's just a straight count. Maybe we don't even need it at all since it's not 
configurable and only ever set to 1.





> VolumeScanner throttle dropped (fast scan enabled) when there is a corrupt 
> block
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-12102
>                 URL: https://issues.apache.org/jira/browse/HDFS-12102
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: datanode, hdfs
>    Affects Versions: 2.8.2
>            Reporter: Ashwin Ramesh
>            Priority: Minor
>             Fix For: 2.8.2
>
>         Attachments: HDFS-12102-001.patch
>
>
> When the Volume scanner sees a corrupt block, it restarts the scan and scans 
> the blocks at much faster rate with a negligible scan period. This is so that 
> it doesn't take 3 weeks to report blocks since a corrupt block means 
> increased likelihood that there are more corrupt blocks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to