[
https://issues.apache.org/jira/browse/HDFS-12085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079809#comment-16079809
]
Yiqun Lin commented on HDFS-12085:
----------------------------------
[~cheersyang], the patch almost looks good to me. One minor comment: I think we
can just change {{private long getTimeDurationHelper}} to {{public long
getTimeDurationHelper}}. I didn't see any difference between
{{getTimeDurationHelper}} and new added method {{getTimeDurationFromValue}}.
Also please add the comment for this method that will be better understand for
callers, like the following:
{code}
/**
* Return time duration in the given time unit. Valid units are encoded in
* properties as suffixes: nanoseconds (ns), microseconds (us), milliseconds
* (ms), seconds (s), minutes (m), hours (h), and days (d).
* @param name Property name
* @param vStr The string value with time unit suffix to be converted.
* @param unit Unit to convert the stored property, if it exists.
*/
public long getTimeDurationHelper(String name, String vStr, TimeUnit unit) {
{code}
> Reconfigure namenode interval fails if the interval was set with time unit
> --------------------------------------------------------------------------
>
> Key: HDFS-12085
> URL: https://issues.apache.org/jira/browse/HDFS-12085
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs, tools
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Priority: Critical
> Attachments: HDFS-12085.001.patch
>
>
> It fails when I set duration with time unit, e.g 5s, error
> {noformat}
> Reconfiguring status for node [localhost:8111]: started at Tue Jul 04
> 08:14:18 PDT 2017 and finished at Tue Jul 04 08:14:18 PDT 2017.
> FAILED: Change property dfs.heartbeat.interval
> From: "3s"
> To: "5s"
> Error: For input string: "5s".
> {noformat}
> time unit support was added via HDFS-9847.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
