[
https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085886#comment-16085886
]
Erik Krogen edited comment on HDFS-12131 at 7/13/17 3:38 PM:
-------------------------------------------------------------
Attaching patch which simply annotates these JMX Bean methods with {{@Metric}}
annotations.
New JMX output from a {{MiniDFSCluster}} (note that these are in the JMX
portion corresponding to the metrics rather than the FSNamesystemMBean):
{code}
"name" : "Hadoop:service=NameNode,name=FSNamesystem",
"modelerType" : "FSNamesystem",
...
"LiveDataNodes" : 1,
"DeadDataNodes" : 0,
"DecomLiveDataNodes" : 0,
"DecomDeadDataNodes" : 0,
"DecommissioningDataNodes" : 0,
"StaleDataNodes" : 0,
"StaleStorages" : 0,
{code}
The six values listed in the description are the ones we are particularly
interested in, but there are a few others which seem like they may be valuable
as metrics as well:
* MaxObjects
* VolumeFailuresTotal
* EstimatedCapacityLostTotal
* NumInMaintenanceLiveDataNodes
* NumInMaintenanceDeadDataNodes
* NumEnteringMaintenanceDataNodes
I am wondering if these should be added as metrics as well? Is there a
downside? cc [~andrew.wang]
was (Author: xkrogen):
Attaching patch which simply annotates these JMX Bean methods with {{@Metric}}
annotations.
New JMX output from a {{MiniDFSCluster}} (note that these are in the JMX
portion corresponding to the metrics rather than the FSNamesystemMBean):
{code}
"name" : "Hadoop:service=NameNode,name=FSNamesystem",
"modelerType" : "FSNamesystem",
...
"LiveDataNodes" : 1,
"DeadDataNodes" : 0,
"DecomLiveDataNodes" : 0,
"DecomDeadDataNodes" : 0,
"DecommissioningDataNodes" : 0,
"StaleDataNodes" : 0,
"StaleStorages" : 0,
{code}
The six values listed in the description are the ones we are particularly
interested in, but there are a few others which seem like they may be valuable
as metrics as well:
* MaxObjects
* VolumeFailuresTotal
* EstimatedCapacityLostTotal
* NumInMaintenanceLiveDataNodes
* NumInMaintenanceDeadDataNodes
* NumEnteringMaintenanceDataNodes
I am wondering if these should be added as metrics as well? Is there a
downside? cc [~andrew.wang]
> Add some of the FSNamesystem JMX values as metrics
> --------------------------------------------------
>
> Key: HDFS-12131
> URL: https://issues.apache.org/jira/browse/HDFS-12131
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs, namenode
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Minor
> Attachments: HDFS-12131.000.patch
>
>
> A number of useful numbers are emitted via the FSNamesystem JMX, but not
> through the metrics system. These would be useful to be able to track over
> time, e.g. to alert on via standard metrics systems or to view trends and
> rate changes:
> * NumLiveDataNodes
> * NumDeadDataNodes
> * NumDecomLiveDataNodes
> * NumDecomDeadDataNodes
> * NumDecommissioningDataNodes
> * NumStaleStorages
> This is a simple change that just requires annotating the JMX methods with
> {{@Metric}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
