[
https://issues.apache.org/jira/browse/HDFS-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091383#comment-16091383
]
Weiwei Yang commented on HDFS-12126:
------------------------------------
Thanks [~linyiqun] for working on this, this is very much needed.
I just read your v2 patch, I think overall it looks good, some comments for
TestOzoneShell
# testCreateBucket: Can we add a test to create a bucket in a non-exist volume?
# line 357: seems bucketInfo can be safely removed
# line 359: this could mis-behave if vol.getBucket doesn't throw any exception,
it will not reach the assert statement in the catch clause
# line 566: it might be over concerned, but there might be slight chance two
calls returns same volume name, can we use UUID or add a prefix as argument for
{{creatVolume}} to completely avoid that?
Thanks
> Ozone: Ozone shell: Add more testing for bucket shell commands
> --------------------------------------------------------------
>
> Key: HDFS-12126
> URL: https://issues.apache.org/jira/browse/HDFS-12126
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, tools
> Affects Versions: HDFS-7240
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-12126-HDFS-7240.001.patch,
> HDFS-12126-HDFS-7240.002.patch
>
>
> Adding more unit tests for ozone bucket commands, similar to HDFS-12118.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
