[ 
https://issues.apache.org/jira/browse/HDFS-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092423#comment-16092423
 ] 

Konstantin Shvachko edited comment on HDFS-11896 at 7/19/17 6:43 PM:
---------------------------------------------------------------------

I was thinking how to fix this. Think jira should fix (1) starting from trunk 
down to 2.7.4.
For (2) there was an easier fix for HDFS-9034, just to swap 2 lines in 
{{HeartbeatManager.register()}}, that is first do {{updateHeartbeatState()}}, 
then {{addDatanode()}}. The former will reset everything to 0 in DND, including 
nonDfsUsed and the latter will be adding 0 then. This would avoid breaking 
followup jiras. We should just add the swapping in branch-2.7 patch here.


was (Author: shv):
I was thinking how to fix this. Think jira should fix (1) starting from trunk 
down to 2.7.4.
For (2) there was an easier fix for HDFS-9034, just to swap 2 lines in 
{{HeartbeatManager.register()}}, that is first do {{updateHeartbeatState()}}, 
then {{addDatanode()}}. The former will reset everything to in DND, including 
nonDfsUsed and the latter will be adding 0 then. This would avoid breaking 
followup jiras. We should just add the swapping in branch-2.7 patch here.

> Non-dfsUsed will be doubled on dead node re-registration in branch-2.7.
> -----------------------------------------------------------------------
>
>                 Key: HDFS-11896
>                 URL: https://issues.apache.org/jira/browse/HDFS-11896
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.3
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>              Labels: release-blocker
>         Attachments: HDFS-11896-002.patch, HDFS-11896-branch-2.7-001.patch, 
> HDFS-11896-branch-2.7-002.patch, HDFS-11896.patch
>
>
>  *Scenario:* 
> i)Make you sure you've non-dfs data.
> ii) Stop Datanode
> iii) wait it becomes dead
> iv) now restart and check the non-dfs data



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to