[
https://issues.apache.org/jira/browse/HDFS-11896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096878#comment-16096878
]
Konstantin Shvachko commented on HDFS-11896:
--------------------------------------------
That's it, good catch. I have only one comment for the patch. In
{{testNonDFSUsedONDeadNodeReReg()}} you can calculate {{dnDesc =
cluster.getNamesystem(0).getBlockManager().getDatanodeManager().getDatanode(dn.getDatanodeId());}}.
That way you will not need to introduce {{DatanodeManager.getDatanodes()}} in
branch-2.7.
+1 otherwise.
Branch 2.7 patch comments:
# Patch should also be updated to not empty storages
# Few empty line problems:
#* Add empty lines before and after {{isHeartbeatedSinceRegistration()}}
#* Remove empty line after {{testNonDFSUsedONDeadNodeReReg()}}
#* Remove empty line inside {{register(}}
#* Remove new empty line before {{setHeartbeatsDisabledForTests()}}
# Remove {{getDatanodes()}}. Don't need it if you calculate {{dnDesc}} as above.
It would be good to run Jenkins on 2.7 patch. So attach it last, please. Thanks
for following up on this.
> Non-dfsUsed will be doubled on dead node re-registration
> --------------------------------------------------------
>
> Key: HDFS-11896
> URL: https://issues.apache.org/jira/browse/HDFS-11896
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.3
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Priority: Blocker
> Labels: release-blocker
> Attachments: HDFS-11896-002.patch, HDFS-11896-003.patch,
> HDFS-11896-004.patch, HDFS-11896-branch-2.7-001.patch,
> HDFS-11896-branch-2.7-002.patch, HDFS-11896-branch-2.7-003.patch,
> HDFS-11896.patch
>
>
> *Scenario:*
> i)Make you sure you've non-dfs data.
> ii) Stop Datanode
> iii) wait it becomes dead
> iv) now restart and check the non-dfs data
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
