[
https://issues.apache.org/jira/browse/HDFS-12117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102645#comment-16102645
]
Wei-Chiu Chuang commented on HDFS-12117:
----------------------------------------
Thanks for the patch! [~wchevreuil]
Overall the patch looks good to me. One comment regarding tests:
Looks like the patch added httpfs server side tests. I'd like to see httpfs
client side tests as well. Specifically, you can add tests in
{{BaseTestHttpFSWith}}, which will be executed by
TestHttpFSFWithSWebhdfsFileSystem, TestHttpFSWithHttpFSFileSystem,
TestHttpFSFWithWebhdfsFileSystem, TestHttpFSFileSystemLocalFileSystem, and can
ensure the client works with these server side implementations.
> HttpFS does not seem to support SNAPSHOT related methods for WebHDFS REST
> Interface
> -----------------------------------------------------------------------------------
>
> Key: HDFS-12117
> URL: https://issues.apache.org/jira/browse/HDFS-12117
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: httpfs
> Affects Versions: 3.0.0-alpha3
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Attachments: HDFS-12117.003.patch, HDFS-12117.004.patch,
> HDFS-12117.005.patch, HDFS-12117.patch.01, HDFS-12117.patch.02
>
>
> Currently, HttpFS is lacking implementation for SNAPSHOT related methods from
> WebHDFS REST interface as defined by WebHDFS documentation [WebHDFS
> documentation|https://archive.cloudera.com/cdh5/cdh/5/hadoop/hadoop-project-dist/hadoop-hdfs/WebHDFS.html#Snapshot_Operations]
> I would like to work on this implementation, following the existing design
> approach already implemented by other WebHDFS methods on current HttpFS
> project, so I'll be proposing an initial patch soon for reviews.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
