[
https://issues.apache.org/jira/browse/HDFS-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103029#comment-16103029
]
Yiqun Lin edited comment on HDFS-11580 at 7/27/17 11:08 AM:
------------------------------------------------------------
Thanks [~nandakumar131] and [~vagarychen] for looking into this. I totally
agree with what you said. Seems I wrote some duplicate async call codes, :P.
Hi [~vagarychen], the latest patch almost looks good to me. Just caught one
thing:
{code}
- KeyValue keyValue = KeyValue.newBuilder()
- .setKey("OverWriteRequested").setValue("true").build();
ChunkInfo chunk = ChunkInfo
.newBuilder()
.setChunkName(key + "_chunk")
.setOffset(0)
.setLen(data.length)
- .addMetadata(keyValue)
.build();
{code}
Here we remove {{OverWriteRequested}} flag, that will lead a different
behaviour I think. That is say if we write a exist key name file. That will be
rejected and throws IOException. But I think this should intend to be the right
way here. So, also +1 from me, :).
was (Author: linyiqun):
Thanks [~nandakumar131] and [~vagarychen] for looking into this. I totally
agree with what you said. Seems I wrote some duplicate async call codes, :P.
Hi [~vagarychen], the latest patch almost looks good to me. Just caught one
thing:
{code}
- KeyValue keyValue = KeyValue.newBuilder()
- .setKey("OverWriteRequested").setValue("true").build();
ChunkInfo chunk = ChunkInfo
.newBuilder()
.setChunkName(key + "_chunk")
.setOffset(0)
.setLen(data.length)
- .addMetadata(keyValue)
.build();
{code}
Here we remove {{OverWriteRequested}} flag, that will lead a different
behaviour I think. That is say if we write a exist key name file. That will be
rejected and throws IOException.
> Ozone: Support asynchronus client API for SCM and containers
> ------------------------------------------------------------
>
> Key: HDFS-11580
> URL: https://issues.apache.org/jira/browse/HDFS-11580
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Yiqun Lin
> Attachments: HDFS-11580-HDFS-7240.001.patch,
> HDFS-11580-HDFS-7240.002.patch, HDFS-11580-HDFS-7240.003.patch,
> HDFS-11580-HDFS-7240.004.patch, HDFS-11580-HDFS-7240.005.patch,
> HDFS-11580-HDFS-7240.006.patch, HDFS-11580-HDFS-7240.007.patch,
> HDFS-11580-HDFS-7240.008.patch, HDFS-11580-HDFS-7240.009.patch,
> HDFS-11580-HDFS-7240.010.patch
>
>
> This is an umbrella JIRA that needs to support a set of APIs in Asynchronous
> form.
> For containers -- or the datanode API currently supports a call
> {{sendCommand}}. we need to build proper programming interface and support an
> async interface.
> There is also a set of SCM API that clients can call, it would be nice to
> support Async interface for those too.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
