[ 
https://issues.apache.org/jira/browse/HDFS-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103235#comment-16103235
 ] 

Ewan Higgs commented on HDFS-12091:
-----------------------------------

I tested it on a simple 1NN 1DN setup and it worked.

Could you add some tests for basic algorithms for 
ProvidedVolumeImpl.containsURI with example URLs. This can be static as well 
for ease of testing.

Nits: indentation in ProvidedVolumeImpl is messed about. Somehow checkstyle 
didn't pick it up.

> [READ] Check that the replicas served from a {{ProvidedVolumeImpl}} belong to 
> the correct external storage
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-12091
>                 URL: https://issues.apache.org/jira/browse/HDFS-12091
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Virajith Jalaparti
>            Assignee: Virajith Jalaparti
>         Attachments: HDFS-12091-HDFS-9806.001.patch
>
>
> A {{ProvidedVolumeImpl}} can only serve blocks that "belong" to it. i.e., for 
> blocks served from a {{ProvidedVolumeImpl}}, the {{baseURI}} of the 
> {{ProvidedVolumeImpl}} should be a prefix of the URI of the blocks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to