[ 
https://issues.apache.org/jira/browse/HDFS-12206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Wang updated HDFS-12206:
-------------------------------
    Attachment: HDFS-12206.001.patch

Patch attached. This fixes up the naming of the public interfaces.

These changes should also be propagated down into BlockManager and classes like 
LowRedundancyBlocks and InvalidateBlocks as well, but that's another big 
renaming pass. I notice that BM also doesn't respect the same naming 
conventions as FSN wrt what's an aggregate, replicated-only, EC-only statistic. 
There's also some inaccuracy wrt "ECBlocks" vs. "ECBlockGroups" in some 
variable names. I'd like to fix these separately, doing behavior changes 
especially in separate JIRAs.

> Rename the split EC / replicated block metrics
> ----------------------------------------------
>
>                 Key: HDFS-12206
>                 URL: https://issues.apache.org/jira/browse/HDFS-12206
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>              Labels: hdfs-ec-3.0-must-do
>         Attachments: HDFS-12206.001.patch
>
>
> Going through the split EC/replicated metrics, I think it'd be better to name 
> the replicated-only metrics with "ReplicatedBlocks" rather than "BlocksStat" 
> for clarity. "Stat" is also not a very descriptive name, so remove it for the 
> EC blocks as well. Finally, fix some inconsistencies that were missed earlier.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to