[ 
https://issues.apache.org/jira/browse/HDFS-12217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106182#comment-16106182
 ] 

Manoj Govindassamy commented on HDFS-12217:
-------------------------------------------

Thanks for the details [~yzhangal]. 
As you are aware, the NameNode is already logging all the exception and stack 
traces with clear messages. *The one pending item we are discussing here is, 
"createSnapshot" shell command to display the long NameNode error stack traces 
in the console along with the error message.* I personally prefer the client 
commands to show only meaningful detailed error messages and not the long error 
stack traces. But heard from you that the general model in the hadoop shell 
commands is to display the stack trace also. I tried the 
{{SnapshotException(string, throwable)}} approach, and still the client shell 
command doesn't see the stack trace. It only sees the error message. Can you 
please point me to the shell command where we display the error stack traces 
also to the console? I can try doing the same. Otherwise, as you recommended 
will take up this into a new jira and can get the others committed. Thanks for 
the review.

> HDFS snapshots doesn't capture all open files when one of the open files is 
> deleted
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-12217
>                 URL: https://issues.apache.org/jira/browse/HDFS-12217
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>         Attachments: HDFS-12217.01.patch, HDFS-12217.02.patch, 
> HDFS-12217.03.patch
>
>
> With the fix for HDFS-11402, HDFS Snapshots can additionally capture all the 
> open files. Just like all other files, these open files in the snapshots will 
> remain immutable. But, sometimes it is found that snapshots fail to capture 
> all the open files in the system.
> Under the following conditions, LeaseManager will fail to find INode 
> corresponding to an active lease 
> * a file is opened for writing (LeaseManager allots a lease), and
> * the same file is deleted while it is still open for writing and having 
> active lease, and
> * the same file is not referenced in any other Snapshots/Trash
> {{INode[] LeaseManager#getINodesWithLease()}} can thus return null for few 
> leases there by causing the caller to trip over and not return all the open 
> files needed by the snapshot manager.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to