[
https://issues.apache.org/jira/browse/HDFS-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108483#comment-16108483
]
Yiqun Lin edited comment on HDFS-12163 at 8/1/17 6:59 AM:
----------------------------------------------------------
Thanks [~cheersyang], very nice working!
I just take a quick look of your patch. i have one comment:
{code}
+ // Overwrite handler number to 20, 200 is not necessary for testing.
+ conf.setInt(KSMConfigKeys.OZONE_KSM_HANDLER_COUNT_KEY, 20);
{code}
Can you define a new var in class {{MiniOzoneCluster}} like following instead
of the number {{20}}? It will be easy to find and be adjusted once we want to
change the value later.
{code}
private static final int KSM_TEST_HANDLER_COUNT = 20;
{code}
Thanks.
was (Author: linyiqun):
Thanks [~cheersyang], very nice working!
I just take a quick look of your patch. i have one comment:
{code}
+ // Overwrite handler number to 20, 200 is not necessary for testing.
+ conf.setInt(KSMConfigKeys.OZONE_KSM_HANDLER_COUNT_KEY, 20);
{code}
Can you define a new var like following instead of the number {{20}}? It will
be easy to find and be adjusted once we want to change the value later.
{code}
private static final int KSM_TEST_HANDLER_COUNT = 20;
{code}
Thanks.
> Ozone: MiniOzoneCluster uses 400+ threads
> -----------------------------------------
>
> Key: HDFS-12163
> URL: https://issues.apache.org/jira/browse/HDFS-12163
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, test
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Weiwei Yang
> Attachments: HDFS-12163-HDFS-7240.001.patch, most_used_threads.png,
> TestOzoneThreadCount20170719.patch, thread_dump.png
>
>
> Checked the number of active threads used in MiniOzoneCluster with various
> settings:
> - Local handlers
> - Distributed handlers
> - Ratis-Netty
> - Ratis-gRPC
> The results are similar for all the settings. It uses 400+ threads for an
> 1-datanode MiniOzoneCluster.
> Moreover, there is a thread leak -- a number of the threads do not shutdown
> after the test is finished. Therefore, when tests run consecutively, the
> later tests use more threads.
> Will post the details in comments.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
