[
https://issues.apache.org/jira/browse/HDFS-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HDFS-1985:
------------------------------
Attachment: hdfs-1985.txt
Attached patch does the above refactoring and cleanup.
While I was at it, I also made the client code check the HTTP response for "200
OK" status. This fixes the client error reporting behavior in the event that
the server throws an exception while processing the request.
> HDFS-1073: Cleanup in image transfer servlet
> --------------------------------------------
>
> Key: HDFS-1985
> URL: https://issues.apache.org/jira/browse/HDFS-1985
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: hdfs-1985.txt
>
>
> The TransferFsImage class has grown several heads and is somewhat confusing
> to follow. This JIRA is to refactor it a little bit.
> - the TransferFsImage class contains static methods to put/get image and
> edits files. It's used by checkpointing nodes. [the same static methods it
> has today]
> - some common code from call sites of TransferFsImage are moved into
> TransferFsImage itself, so it presents a cleaner interface to checkpointers
> - the non-static parts of TransferFsImage are moved to an inner class of
> GetImageServlet called GetImageParams, since they were only responsible for
> parameter parsing/validation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
