[
https://issues.apache.org/jira/browse/HDFS-12224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112194#comment-16112194
]
Arpit Agarwal commented on HDFS-12224:
--------------------------------------
Thanks for the updated patch [~hanishakoneru].
# Can you please add the {{@VisibleForTesting}} annotation to
getNumEditLogsSynced?
# We already instantiate a MetricsRegistry via JournalMetrics. Can we expose
the new metric from there?
The patch looks good otherwise.
> Add tests to TestJournalNodeSync for sync after JN downtime
> -----------------------------------------------------------
>
> Key: HDFS-12224
> URL: https://issues.apache.org/jira/browse/HDFS-12224
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Attachments: HDFS-12224.001.patch, HDFS-12224.002.patch,
> HDFS-12224.003.patch
>
>
> Adding unit tests for testing JN sync when the JN has a downtime and is
> formatted.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
