[
https://issues.apache.org/jira/browse/HDFS-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116273#comment-16116273
]
SammiChen commented on HDFS-11975:
----------------------------------
Hi [~luhuichun], thanks for working on this. The last patch looks overall good.
Only small nits,
HDFSErasureCoding.md
1. By default, the 'dfs.namenode.ec.system.default.policy' is "RS-6-3-64K".
Here lower case "k" is required, not the upper case.
2. ...the default EC policy will be used even though no policy name is passed
as an argument...., suggest change "even though" to "when"
hdfs-default.xml
add "RS-6-3-64k" to the value of property
"dfs.namenode.ec.system.default.policy"
ErasureCodingPolicyManager
The type of defaultPolicyName is more proper to be String instead of String[],
use "conf.getTrimmed" to get the value
Regarding code style, for code like
"ArrayUtils.addAll(enablePolicyNames,defaultPolicyName);", space is required
between "," and "defaultPolicyName". There are several such cases, kindly
double check it.
> Provide a system-default EC policy
> ----------------------------------
>
> Key: HDFS-11975
> URL: https://issues.apache.org/jira/browse/HDFS-11975
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Affects Versions: 3.0.0-alpha3
> Reporter: Lei (Eddy) Xu
> Assignee: luhuichun
> Attachments: HDFS-11975-001.patch, HDFS-11975-002.patch,
> HDFS-11975-003.patch, HDFS-11975-004.patch, HDFS-11975-005.patch,
> HDFS-11975-006.patch, HDFS-11975-007.patch, HDFS-11975-008.patch,
> HDFS-11975-009.patch
>
>
> From the usability point of view, it'd be nice to be able to specify a
> system-wide EC policy, i.e., in {{hdfs-site.xml}}. For most of users / admin
> / downstream projects, it is not necessary to know the tradeoffs of the EC
> policy, considering that it requires the knowledge of EC, the actual physical
> topology of the clusters, and many other factors (i.e., network, cluster size
> and etc).
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
