[ https://issues.apache.org/jira/browse/HDFS-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116366#comment-16116366 ]
Weiwei Yang edited comment on HDFS-12199 at 8/7/17 10:02 AM: ------------------------------------------------------------- Hi [~msingh] Thanks for working on this. I maybe able to get more details from the design doc you are going to upload to HDFS-11704, before that becomes to be available, a few comments/questions *Constants* Can we name the schema to {{oz}} instead of {{ozfs}} ? I checked some existing FS implementations, their schema are like, "oss", "adl", "s3a" etc. none of them contains "fs" suffix. *OzoneFileSystem* 1. Since oz FS is initiated per bucket, we need to ensure bucket existence during the {{initialize}}. But there seems no code to check this. 2. line 84 - 88, question: if a client passes, e.g {{/vol/bucket/ppp}}, as the URI path to init oz FS, is this a valid configuration or an exception to throw? 3. line 99, line 109: can we move constants "http://" and "/user" to {{Constants}} class? 4. Can you implement at least one FS API in {{OzoneFileSystem}} to prove this is working? Thank you. was (Author: cheersyang): Hi [~msingh] Thanks for working on this. I maybe able to get more details from the design doc you are going to upload to HDFS-11704, before that becomes to be available, a few comments/questions *Constants* Can we name the schema to {{oz}} instead of {{ozfs}} ? I checked some existing FS implementations, their schema are like, "oss", "adl", "s3a" etc. none of them contains "fs" suffix. *OzoneFileSystem* 1. Since oz FS is initiated per bucket, we need to ensure bucket existence during the {{initialize}}. But there seems no code to check this. 2. line 84 - 88, question: if a client passes, e.g /vol/bucket/ppp, as the URI path to init oz FS, is this a valid configuration or an exception to throw? 3. line 99, line 109: can we move constants "http://" and "/user" to {{Constants}} class? 4. Can you implement at least one FS API in {{OzoneFileSystem}} to prove this is working? Thank you. > Ozone: OzoneFileSystem: OzoneFileystem initialization code > ---------------------------------------------------------- > > Key: HDFS-12199 > URL: https://issues.apache.org/jira/browse/HDFS-12199 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Mukul Kumar Singh > Assignee: Mukul Kumar Singh > Fix For: HDFS-7240 > > Attachments: HDFS-12199-HDFS-7240.001.patch > > > This jira will be used to add OzoneFileySystem initialization code. This jira > is based out of HDFS-11704. I will attach a design document to HDFS-11704. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org