Anatoli Shein updated HDFS-12237:
    Attachment: HDFS-12237.HDFS-8707.002.patch

After further consideration I removed the CHECK_LIBRARY_EXISTS for protobuf 
because it requires a function name from the library, and moreover it takes it 
in mangled format. This makes this check dependent on both the protobuf library 
version and the compiler version. Istead of this check, in order to avoid build 
failures when protobuf library is not yet compiled at the time of the 
PROTOC_IS_COMPATIBLE check I changed the message to be a warning rather than a 
fatal error.

> libhdfs++: PROTOC_IS_COMPATIBLE check fails if protobuf library is built from 
> source
> ------------------------------------------------------------------------------------
>                 Key: HDFS-12237
>                 URL: https://issues.apache.org/jira/browse/HDFS-12237
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: Anatoli Shein
>            Assignee: Anatoli Shein
>         Attachments: HDFS-12237.HDFS-8707.000.patch, 
> HDFS-12237.HDFS-8707.001.patch, HDFS-12237.HDFS-8707.002.patch
> Looks like the PROTOC_IS_COMPATIBLE check fails when Protobuf library is 
> built from source. This happens because the check if performed during the 
> cmake phase, and the protobuf library needed for this test is build from 
> source only during the make phase, so the check fails with "ld: cannot find 
> -lprotobuf" because it was not built yet. We should probably restrict this 
> test to run only in cases when Protobuf library is already present and not 
> being built from source.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to