[ https://issues.apache.org/jira/browse/HDFS-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118783#comment-16118783 ]
James Clampffer commented on HDFS-12237: ---------------------------------------- Disregard my last comment, I misread the patch and thought it was getting rid of a line. Adding PROTOBUF_INCLUDE_DIRS for try_compile makes sense, and the warning should be sufficient to help people sort out linking issues. +1 > libhdfs++: PROTOC_IS_COMPATIBLE check fails if protobuf library is built from > source > ------------------------------------------------------------------------------------ > > Key: HDFS-12237 > URL: https://issues.apache.org/jira/browse/HDFS-12237 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client > Reporter: Anatoli Shein > Assignee: Anatoli Shein > Attachments: HDFS-12237.HDFS-8707.000.patch, > HDFS-12237.HDFS-8707.001.patch, HDFS-12237.HDFS-8707.002.patch > > > Looks like the PROTOC_IS_COMPATIBLE check fails when Protobuf library is > built from source. This happens because the check if performed during the > cmake phase, and the protobuf library needed for this test is build from > source only during the make phase, so the check fails with "ld: cannot find > -lprotobuf" because it was not built yet. We should probably restrict this > test to run only in cases when Protobuf library is already present and not > being built from source. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org