[
https://issues.apache.org/jira/browse/HDFS-12277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated HDFS-12277:
-------------------------------
Attachment: HDFS-12277.001.patch
Address checkstyle issue (line longer than 80 chars). Failed UT and findbugs
seems irrelevant.
> NNThroughputBenchmark should use cumulativeTime to calculate ops per second.
> ----------------------------------------------------------------------------
>
> Key: HDFS-12277
> URL: https://issues.apache.org/jira/browse/HDFS-12277
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: benchmarks, tools
> Reporter: Michael Han
> Assignee: Michael Han
> Priority: Minor
> Attachments: HDFS-12277.000.patch, HDFS-12277.001.patch
>
>
> {{NNThroughputBenchmark$getOpsPerSecond}} is using {{elapsedTime}} to
> calculate ops per second. {{elapsedTime}} is the time used to measure the
> time from the start to the finish of the benchmark main thread, and it's also
> the total execution time of the single slowest benchmark worker thread. To
> measure ops per second, we should use the total execution time of all worker
> threads, which is {{cumulativeTime}}. Otherwise, we could get bogus result,
> e.g. given same load, the more client threads we have (controlled by
> {{-threads}}), the larger ops per second the number would be, with the same
> NN and its server side configurations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
