Wei-Chiu Chuang commented on HDFS-12054:

Looks good to me.
Would it be feasible to add tests in 
TestSafeMode#testOperationsWhileInSafeMode? Similarly for HDFS-12066 as well.


> FSNamesystem#addECPolicies should call checkNameNodeSafeMode() to ensure 
> Namenode is not in safemode
> ----------------------------------------------------------------------------------------------------
>                 Key: HDFS-12054
>                 URL: https://issues.apache.org/jira/browse/HDFS-12054
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>    Affects Versions: 3.0.0-alpha3
>            Reporter: lufei
>            Assignee: lufei
>              Labels: hdfs-ec-3.0-nice-to-have
>         Attachments: HDFS-12054.001.patch
> In the process of FSNamesystem#addECPolicies, it would be better to  call 
> checkNameNodeSafeMode() to ensure NN is not in safemode.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to