[ 
https://issues.apache.org/jira/browse/HDFS-11303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122161#comment-16122161
 ] 

Wei-Chiu Chuang commented on HDFS-11303:
----------------------------------------

Hi Chen Zhang. Your 002 patch is mostly good. I updated your latest patch to 
address some comments I had. Hope you don't mind.

In addition,
* Added a fail() to ensure DFSInputStream#read() fails as expected.
* Because DFSInputStream#read() throws exception, the asserts are not 
reachable. Moved them to catch block.
* Replaced the deprecated method {{IOUtils.cleanup}} with 
{{IOUtils.cleanupWithLogger}}.

Regarding my first comment, I verified the test fails without the fix, and 
passes with the fix.

> Hedged read might hang infinitely if read data from all DN failed 
> ------------------------------------------------------------------
>
>                 Key: HDFS-11303
>                 URL: https://issues.apache.org/jira/browse/HDFS-11303
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Chen Zhang
>            Assignee: Chen Zhang
>         Attachments: HDFS-11303-001.patch, HDFS-11303-001.patch, 
> HDFS-11303-002.patch, HDFS-11303-002.patch, HDFS-11303.003.patch
>
>
> Hedged read will read from a DN first, if timeout, then read other DNs 
> simultaneously.
> If read all DN failed, this bug will cause the future-list not empty(the 
> first timeout request left in list), and hang in the loop infinitely



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to