[ 
https://issues.apache.org/jira/browse/HDFS-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122343#comment-16122343
 ] 

Anu Engineer commented on HDFS-12238:
-------------------------------------

[~ajayydv] Thanks for the contribution, Some minor comments.

* There is a bunch of check-style warnings which are mostly more than "80 chars 
in a line" warning. 
* I am not sure if the changes in {{Ozonebucket.java}} and {{TestKeys.java}} 
are part of this change.
* Also in the test {{TestOzoneContainer#testInvalidRequest}}, can we be more 
specific instead of just catching IllegalArgumentException.
 -- something like catching an exception and verifying that it is indeed what 
you expect. May be something like {{GenericTestUtils.assertExceptionContains}} 
or JUnit specific checkers can be used. 


> Ozone: Add valid trace ID check in sendCommandAsync
> ---------------------------------------------------
>
>                 Key: HDFS-12238
>                 URL: https://issues.apache.org/jira/browse/HDFS-12238
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Ajay Yadav
>              Labels: newbie
>         Attachments: HDFS-12238-HDFS-7240.01.patch
>
>
> In the function {{XceiverClientHandler#sendCommandAsync}} we should add a 
> check 
> {code}
>    if(StringUtils.isEmpty(request.getTraceID())) {
>       throw new IllegalArgumentException("Invalid trace ID");
>     }
> {code}
> To ensure that ozone clients always send a valid trace ID. However, when you 
> do that a set of current tests that do add a valid trace ID will fail. So we 
> need to fix these tests too.
> {code}
>   TestContainerMetrics.testContainerMetrics
>   TestOzoneContainer.testBothGetandPutSmallFile
>   TestOzoneContainer.testCloseContainer
>   TestOzoneContainer.testOzoneContainerViaDataNode
>   TestOzoneContainer.testXcieverClientAsync
>   TestOzoneContainer.testCreateOzoneContainer
>   TestOzoneContainer.testDeleteContainer
>   TestContainerServer.testClientServer
>   TestContainerServer.testClientServerWithContainerDispatcher
>   TestKeys.testPutAndGetKeyWithDnRestart
> {code}
> This is based on a comment from [~vagarychen] in HDFS-11580.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to