[ 
https://issues.apache.org/jira/browse/HDFS-12005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124321#comment-16124321
 ] 

Hadoop QA commented on HDFS-12005:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} HDFS-7240 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 
45s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 18m 
17s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
19s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
54s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m  
2s{color} | {color:green} HDFS-7240 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  
2s{color} | {color:green} HDFS-7240 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 13m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
14s{color} | {color:green} root: The patch generated 0 new + 4 unchanged - 1 
fixed = 4 total (was 5) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m  
8s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 10s{color} 
| {color:red} hadoop-hdfs in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  0m 
34s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}162m 56s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.cblock.TestCBlockReadWrite |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 |
|   | hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting |
|   | hadoop.cblock.TestBufferManager |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 |
|   | hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 |
|   | hadoop.ozone.web.client.TestKeys |
| Timed out junit tests | org.apache.hadoop.ozone.web.client.TestKeysRatis |
|   | org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainerRatis |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HDFS-12005 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12881544/HDFS-12005-HDFS-7240.002.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 55dfd25ed602 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | HDFS-7240 / 531d9ce |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| unit | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20670/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20670/testReport/ |
| asflicense | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20670/artifact/patchprocess/patch-asflicense-problems.txt
 |
| modules | C: hadoop-common-project/hadoop-common 
hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/20670/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Ozone: Web interface for SCM
> ----------------------------
>
>                 Key: HDFS-12005
>                 URL: https://issues.apache.org/jira/browse/HDFS-12005
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>         Attachments: HDFS-12005-HDFS-7240.001.patch, 
> HDFS-12005-HDFS-7240.002.patch
>
>
> This is a propsal about how a web interface could be implemented for SCM (and 
> later for KSM) similar to the namenode ui.
> 1. JS framework
> There are three big option here. 
> A.) One is to use a full featured web framework with all the webpack/npm 
> minify/uglify magic. Build time the webpack/npm scripts should be run and the 
> result will be added to the jar file. 
> B.) It could be simplified if the generated minified/uglified js files are 
> added to the project on commit time. It requires an additional step for every 
> new patch (to generate the new minified javascripts) but doesn't require 
> additional JS build tools during the build.
> C.) The third option is to make it as simple as possible similar to the 
> current namenode ui which uses javascript but every dependency is commited 
> (without JS minify/uglify and other preprocessing).
> I prefer to the third one as:
>  * I have seen a lot of problems during frequent builds od older tez-ui 
> versions (bower version mismatch, npm version mismatch, npm transitive 
> dependency problems, proxy problem with older versions). All they could be 
> fixed but requires additional JS/NPM magic/knowledge. Without additional npm 
> build step the hdfs projects build could be kept more simple.
>  * The complexity of the planned SCM/KSM ui (hopefully it will remain simple) 
> doesn't require more sophisticated model. (Eg. we don't need JS require as we 
> need only a few controllers)
>  * HDFS developers mostly backend developers and not JS developers
> 2. Frameworks 
> The big advantages of a more modern JS framework is the simplified 
> programming model (for example with two way databinding) I suggest to use a 
> more modern framework (not just jquery) which supports plain js (not just 
> ECMA2015/2016/typescript) and just include the required js files in the 
> projects (similar to the included bootstrap or as the existing namenode ui 
> works). 
>  
>   * React could be a good candidate but it requires more library as it's just 
> a ui framework, even the REST calls need separated library. It could be used 
> with plain javascript instead of JSX and classes but not straightforward, and 
> it's more verbose.
>  
>   * Ember is used in yarnui2 but the main strength of the ember is the CLI 
> which couldn't be used for the simplified approach easily. I think ember is 
> best with the A.) option
>   * Angular 1 is a good candidate (but not so fancy). In case of angular 1 
> the component based approach should be used (in that case later it could be 
> easier to migrate to angular 2 or react)
>   * The mainstream side of Angular 2 uses typescript, it could work with 
> plain JS but it could require additional knowledge, most of the tutorials and 
> documentation shows the typescript approach.
> I suggest to use angular 1 or react. Maybe angular is easier to use as don't 
> need to emulate JSX with function calls, simple HTML templates could be used.
> 3. Backend
> I would prefer the approach of the existing namenode ui where the backend is 
> just the jmx endpoint. To keep it as simple as possible I suggest to try to 
> avoid dedicated REST backend if possible. Later we can use REST api of 
> SCM/KSM if they will be implemented. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to