[
https://issues.apache.org/jira/browse/HDFS-10631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126225#comment-16126225
]
Subru Krishnan commented on HDFS-10631:
---------------------------------------
[~elgoiri], I looked at patch, please find my comments below:
* There are quite a few Yetus warnings, can you fix those.
* I see that *createRootDirRecursively* is also common across impls, so should
move it to {{ZKCuratorManager}}. It may be better to open a follow up Hadoop
jira with the new additions and rebase off that.
* In {{StateStoreZooKeeperImpl::get}}, we are deleting corrupted records only
if they are empty, what about the case when we cannot create record type?
* In {{StateStoreZooKeeperImpl::putAll/remove/removeAll}}, do we expect the
record class to be different for each record? If not, we cannot move the
*getRecordClass* outside the loop.
> Federation State Store ZooKeeper implementation
> -----------------------------------------------
>
> Key: HDFS-10631
> URL: https://issues.apache.org/jira/browse/HDFS-10631
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: fs
> Reporter: Íñigo Goiri
> Assignee: Jason Kace
> Attachments: HDFS-10631-HDFS-10467-001.patch,
> HDFS-10631-HDFS-10467-002.patch, HDFS-10631-HDFS-10467-003.patch,
> HDFS-10631-HDFS-10467-004.patch, HDFS-10631-HDFS-10467-005.patch,
> HDFS-10631-HDFS-10467-006.patch, HDFS-10631-HDFS-10467-007.patch
>
>
> State Store implementation using ZooKeeper.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
