[ 
https://issues.apache.org/jira/browse/HDFS-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127658#comment-16127658
 ] 

Manoj Govindassamy commented on HDFS-11912:
-------------------------------------------

[~ghuangups],
Thanks for working on the patch revision. Looks good overall. +1 pending 
following items.
* In the pre-commit test for v03 patch, the test added in the patch 
TestRandomOpsWithSnapshots timed out. Any reasons why the test failed? I tried 
running the test manually and it ran for 5 minutes and passed. May be on the 
slower machines its taking a longer time to run. 
* I can see some checkstyle issues in the patch. Can you please take care of 
them? The previous checkstyle results from the precommit test expired. 
Triggered a new precommit test 
https://builds.apache.org/job/PreCommit-HDFS-Build/20706/, and we will have the 
results soon.


> Add a snapshot unit test with randomized file IO operations
> -----------------------------------------------------------
>
>                 Key: HDFS-11912
>                 URL: https://issues.apache.org/jira/browse/HDFS-11912
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: hdfs
>            Reporter: George Huang
>            Assignee: George Huang
>            Priority: Minor
>              Labels: TestGap
>         Attachments: HDFS-11912.001.patch, HDFS-11912.002.patch, 
> HDFS-11912.003.patch
>
>
> Adding a snapshot unit test with randomized file IO operations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to