[
https://issues.apache.org/jira/browse/HDFS-12214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127659#comment-16127659
]
Surendra Singh Lilhore commented on HDFS-12214:
-----------------------------------------------
Thanks [~rakeshr] for the patch.
Patch LGTM, one minor comment.
{code}
+ String nsId = DFSUtil.getNamenodeNameServiceId(conf);
+ boolean isHaEnabled = HAUtil.isHAEnabled(conf, nsId);
+ if (!isHaEnabled) {
+ startSPS();
}
{code}
In {{BlockManager#activate()}} we no need to start SPS thread, for HA and
Non-HA both the case {{FSNamesystem#startActiveServices()}} will start the SPS
services.
> [SPS]: Fix review comments of StoragePolicySatisfier feature
> ------------------------------------------------------------
>
> Key: HDFS-12214
> URL: https://issues.apache.org/jira/browse/HDFS-12214
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-12214-HDFS-10285-00.patch,
> HDFS-12214-HDFS-10285-01.patch, HDFS-12214-HDFS-10285-02.patch,
> HDFS-12214-HDFS-10285-03.patch, HDFS-12214-HDFS-10285-04.patch,
> HDFS-12214-HDFS-10285-05.patch, HDFS-12214-HDFS-10285-06.patch,
> HDFS-12214-HDFS-10285-07.patch
>
>
> This sub-task is to address [~andrew.wang]'s review comments. Please refer
> the [review
> comment|https://issues.apache.org/jira/browse/HDFS-10285?focusedCommentId=16103734&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16103734]
> in HDFS-10285 umbrella jira.
> # Rename configuration property 'dfs.storage.policy.satisfier.activate' to
> 'dfs.storage.policy.satisfier.enabled'
> # Disable SPS feature by default.
> # Rather than using the acronym (which a user might not know), maybe rename
> "-isSpsRunning" to "-isSatisfierRunning"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
