[
https://issues.apache.org/jira/browse/HDFS-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128430#comment-16128430
]
Akira Ajisaka commented on HDFS-12269:
--------------------------------------
Mostly looks good to me. Two minor comments:
1. Would you remove unused imports in DistributedFileSystem.java and
ClientNamenodeProtocolServerSideTranslatorPB.java?
2. In {{Map<String, String> ecCodecs = new HashMap<String, String>();}},
{{HashMap<String, String>()}} can be shortened to {{HashMap<>()}}.
> Better to return a Map rather than HashMap in getErasureCodingCodecs
> --------------------------------------------------------------------
>
> Key: HDFS-12269
> URL: https://issues.apache.org/jira/browse/HDFS-12269
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
> Reporter: Huafeng Wang
> Assignee: Huafeng Wang
> Priority: Minor
> Attachments: HDFS-12269.001.patch, HDFS-12269.002.patch
>
>
> Currently the getErasureCodingCodecs function defined in ClientProtocal
> returns a Hashmap:
> {code:java}
> HashMap<String, String> getErasureCodingCodecs() throws IOException;
> {code}
> It's better to return a Map.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
