[
https://issues.apache.org/jira/browse/HDFS-12248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brahma Reddy Battula updated HDFS-12248:
----------------------------------------
Attachment: HDFS-12248-002.patch
Thanks [~shahrs87] and [~hkoneru] for taking look into this issue.
bq.We should have an AND instead of OR here to capture the case of no exception.
Yup, I missed.
bq.isPrimaryCheckPointer should be outside the if condition. If the ANN update
was not successful, then isPrimaryCheckPointer should be set to false.
In non-exception case, {{success=false}}, if ANN fails to update, so that will
be assigned to {{false}} only
Uploaded the patch kindly review.
> SNN will not upload fsimage on IOE and Interrupted exceptions
> -------------------------------------------------------------
>
> Key: HDFS-12248
> URL: https://issues.apache.org/jira/browse/HDFS-12248
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rolling upgrades
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Priority: Critical
> Attachments: HDFS-12248-002.patch, HDFS-12248.patch
>
>
> Related to HDFS-9787. When fsimage uploading to ANN, if there is any
> interrupt or IOE comes {{isPrimaryCheckPointer}} set to
> {{false}}.Rollingupgrade triggered same time then It does the checkpoint
> without sending the fsimage since {{sendRequest}} will be {{false}}.
> So,here {{rollback}} image will not sent to ANN.
> {code}
> } catch (ExecutionException e) {
> ioe = new IOException("Exception during image upload: " +
> e.getMessage(),
> e.getCause());
> break;
> } catch (InterruptedException e) {
> ie = e;
> break;
> }
> }
> lastUploadTime = monotonicNow();
> // we are primary if we successfully updated the ANN
> this.isPrimaryCheckPointer = success;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
