Brahma Reddy Battula commented on HDFS-5040:

[~kshukla] Nice and very neat work here. Appreciate it!. Latest patch almost 
good to me. apart following minor nits from test.
1) Instead of following in  {{TestAuditLogger#testWebHdfsAuditLogger}}, can you 
reset the log count like {{testAuditLoggerWithSetPermission}}..?

170           assertEquals("getfileinfo", DummyAuditLogger.lastCommand);
171           int logCount = DummyAuditLogger.logCount;
Just add this
2) {{TestNameNodeMXBean}} can we handle like this..?
if (opType.equals(TopConf.ALL_CMDS)) {
            expected = 2 * NUM_OPS + 2;
          } else if (opType.equals("datanodeReport")) {
            expected = 2;
          } else {

Would any one else like to chime in? Thanks

> Audit log for admin commands/ logging output of all DFS admin commands
> ----------------------------------------------------------------------
>                 Key: HDFS-5040
>                 URL: https://issues.apache.org/jira/browse/HDFS-5040
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: namenode
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Raghu C Doppalapudi
>            Assignee: Kuhu Shukla
>              Labels: BB2015-05-TBR
>         Attachments: HDFS-5040.001.patch, HDFS-5040.004.patch, 
> HDFS-5040.005.patch, HDFS-5040.006.patch, HDFS-5040.007.patch, 
> HDFS-5040.patch, HDFS-5040.patch, HDFS-5040.patch
> enable audit log for all the admin commands/also provide ability to log all 
> the admin commands in separate log file, at this point all the logging is 
> displayed on the console.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to